From 5115e6524fbca0d8668c785773d39eff27de6607 Mon Sep 17 00:00:00 2001 From: Christian Mauderer Date: Wed, 2 Aug 2023 07:41:37 +0200 Subject: bsps/shared: Fix Coverity warning in MCP7940M Fixes the following Coverity warning: ** CID 1539495: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bsps/shared/dev/rtc/mcp7940m.c: 317 in mcp7940m_set_time() Basically coverity warns that (buf[...] & 0x7) can't be bigger than 7. Just remove the unnecessary comparison. --- bsps/shared/dev/rtc/mcp7940m.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bsps/shared/dev/rtc/mcp7940m.c b/bsps/shared/dev/rtc/mcp7940m.c index 78a4f21b58..1abc5faaad 100644 --- a/bsps/shared/dev/rtc/mcp7940m.c +++ b/bsps/shared/dev/rtc/mcp7940m.c @@ -312,9 +312,8 @@ static int mcp7940m_set_time(int minor, const rtems_time_of_day *time) } if (rv == 0) { - /* Make sure weekday is in range. Otherwise it's not relevant. */ - if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1 || - RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) > 7) { + /* Make sure weekday is not 0 (out of range). Otherwise it's not used. */ + if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1) { buf[REG_RTCWKDAY] &= ~RTCWKDAY_WKDAY_MASK; buf[REG_RTCWKDAY] |= RTCWKDAY_WKDAY(1); } -- cgit v1.2.3